Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

<Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. #1956

Merged
merged 15 commits into from
Sep 20, 2018
Merged

<Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. #1956

merged 15 commits into from
Sep 20, 2018

Conversation

quentin-
Copy link
Contributor

@quentin- quentin- commented Apr 30, 2018 •
edited
Loading

👋,

This PR:

  • marks the client optional in both context and props in all three component
  • update the client correctly when props are updated.
  • always use the prop client over the context
  • throw error if no client

Checklist:

  • Make sure all of the significant new logic is covered by tests

@quentin- quentin- changed the title Mark Query context client as optional and always use props client ove… Consolidate how <Query /> and <Mutation /> fetch the apollo client from Jun 2, 2018
@quentin- quentin- changed the title Consolidate how <Query /> and <Mutation /> fetch the apollo client from <Subscription /> <Query /> & <Mutation /> consume the apollo client the same way. Jun 8, 2018
@quentin- quentin- mentioned this pull request Jun 17, 2018
Closed
3 tasks
@hwillson hwillson mentioned this pull request Jun 21, 2018
Closed
3 tasks
@hwillson hwillson self-assigned this Jun 21, 2018
hwillson
hwillson approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @quentin-! We should be all set here - LGTM!

@hwillson hwillson merged commit c21e005 into apollographql:master Sep 20, 2018
@dependencies dependencies bot mentioned this pull request Sep 26, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@rosskevin rosskevin rosskevin approved these changes

Assignees

@hwillson hwillson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quentin- @rosskevin @hwillson